Trim passwords obtained as command result #1871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MaciejG604 force-pushed the trim-ending-new-line-from-command-results branch from 8a65e33 to 7d3720f Compare 
lwronski approved these changes Feb 20, 2023
MaciejG604 changed the title MaciejG604 changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
If you follow the instruction for publishing from github actions,
when providing github token with this snippet:
scala-cli config github.token command:pbpaste --password-valueand then proceeding to:
scala-cli publish setup . --cione gets an error
Error: java.lang.IllegalArgumentException: Illegal character(s) in message header valuedue to the value in config ending with'\n'.Trimming the value obtained by calling a command fixes that.