Ensure compiler options relevant to syntax rewriting don't require being passed after -O #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Gedochao added SIP-46 
…ing passed after `-O`: - `-rewrite` - `-new-syntax` - `-old-syntax` - `-source:<target>` - `-indent` - `-no-indent`
Gedochao force-pushed the simpler-syntax-rewriting branch from b3211a6 to 0ee742d Compare 
alexarchambault approved these changes Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Inspired by scala/improvement-proposals#46 (comment)
With these changes, the following
scalacoptions don't require being passed with-O.-rewrite-new-syntax-old-syntax-source:<target>-indent-no-indentThis allows for simpler commands when automatically migrating to newer Scala 3 syntax.
i.e. instead of
one can just use