Skip to content

Update scala3 to 3.2.0 #1314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Gedochao merged 6 commits into from
Sep 6, 2022
Merged

Update scala3 to 3.2.0 #1314

Gedochao merged 6 commits into from
Sep 6, 2022

Conversation

@lwronski
Copy link
Contributor

@lwronski lwronski commented Aug 31, 2022 •
edited
Loading 

1 targets failed dummy.amm[3.2.0].resolvedRunIvyDeps Resolution failed for 1 modules: -------------------------------------------- com.lihaoyi:ammonite_3.2.0:2.5.4-19-cd76521f not found: /Users/lwronski/.ivy2/local/com.lihaoyi/ammonite_3.2.0/2.5.4-19-cd76521f/ivys/ivy.xml not found: https://repo1.maven.org/maven2/com/lihaoyi/ammonite_3.2.0/2.5.4-19-cd76521f/ammonite_3.2.0-2.5.4-19-cd76521f.pom
  • Remove options compile deps in cli-options module - I have to remove compile deps to options because cli-options module is compiled using scala 2.13.8 which can not read TASTy files from module options which is built by 3.2.0. It should work when 2.13.9 will be published with adding support for reading TASTy files, but IMO we should remove compile deps.
@lwronski lwronski force-pushed the dump-scala branch 3 times, most recently from be1a8c8 to b5931aa Compare September 5, 2022 14:16
@lwronski lwronski marked this pull request as ready for review September 5, 2022 15:15
@Gedochao Gedochao added the dependencies Pull requests that update a dependency file label Sep 6, 2022
Gedochao
Gedochao approved these changes Sep 6, 2022
View reviewed changes
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@Gedochao Gedochao merged commit 21b179c into VirtusLab:main Sep 6, 2022
@lwronski lwronski deleted the dump-scala branch November 5, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

2 participants

@lwronski @Gedochao