Define output option for package command with using directives #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lwronski reviewed Jul 29, 2022
Contributor
lwronski left a comment
lwronski left a comment There was a problem hiding this comment.
LGTM, I suggest only to add a documentation.
wleczny force-pushed the output-option-for-using-directives branch 3 times, most recently from 2d111ad to 5d94ea7 Compare 
Gedochao reviewed Aug 1, 2022
Contributor
Gedochao left a comment
Gedochao left a comment There was a problem hiding this comment.
Left some language nitpick comments on the docs, otherwise LGTM
wleczny force-pushed the output-option-for-using-directives branch from 5d94ea7 to 7f9b020 Compare Gedochao approved these changes Aug 1, 2022
lwronski approved these changes Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.