Tweaking #1105
Merged
Tweaking #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alexarchambault force-pushed the tweaking branch 2 times, most recently from 7611e15 to 1edb246 Compare 
And actually print them in BloopRifleLogger.error
alexarchambault force-pushed the tweaking branch 3 times, most recently from a7ea7e9 to fdfc518 Compare Previously, we were calling redirectOutput / redirectError to redirect the Bloop output to a (single) file. But the resulting output file seemed to contain truncated lines, or to be missing some output. Same with redirectErrorStream(true). My guess is that the JVM was opening the output file twice (once for stdout, once for stderr), and writing to the two file descriptors at the same time was a problem. With these changes, we start the Bloop server via a shell script, and make it do "> output-file 2>&1". The shell handles redirecting both stdout and stderr to the same file better it seems, opening the file only once under-the-hood I think. Rather than doing this via a shell script, we could try to do the same as what the shell does, by calling ourselves system calls to open the output file (open), duplicating it (dup2?), then fork / exec. That's more cumbersome (we'd likely have to rely on JNI, or JNA + GraalVM API, to have it work both from the JVM and the native launcher), so we should probably do it only if ever using the shell ends up being a problem IMO…
alexarchambault force-pushed the tweaking branch from fdfc518 to 5797656 Compare 
lwronski approved these changes Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR:
-featureto them and address its warnings)