CDNClient: Cope with longer manifest descriptions for some depots #437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some depots now have a dict like {"public": {"gid": GID, ...}, ...} where we would traditionally have seen a flat dict {"public": GID, ...}. Not all depots have this: at the time of writing, 1628350 "Steam Linux Runtime - Sniper" does, but 1391110 "Steam Linux Runtime - Soldier" does not. Presumably this is a change that is being rolled out gradually to let the Steam client give better estimates of the size of a depot. Cope with either format, by retrieving the gid field if the nested dict is present. Resolves: ValvePython#436 Signed-off-by: Simon McVittie <smcv@collabora.com> 
bob-beck pushed a commit to openbsd/ports that referenced this pull request Aug 2, 2023
CDNClient: Cope with longer manifest descriptions for some depots should fix most depot download scenarios, where for a while depot and manifest flags needed to be provided manually. Now it should be enough to provide -a <AppId> +/- -os linux64
| I made a fork that incorporates this PR as well as several other pending PRs in this repo. I don't really particularly want to be the new maintainer for this, but if I'm still using it I may as well. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some depots now have a dict like
{"public": {"gid": GID, ...}, ...}where we would traditionally have seen a flat dict{"public": GID, ...}. Not all depots have this: at the time of writing,1628350 "Steam Linux Runtime - Sniper" does, but
1391110 "Steam Linux Runtime - Soldier" does not. Presumably this is a change that is being rolled out gradually to let the Steam client give better estimates of the size of a depot.
Cope with either format, by retrieving the gid field if the nested dict is present.
Resolves: #436