Skip to content

Conversation

@Axorax
Copy link
Collaborator

@Axorax Axorax commented Nov 4, 2024

No description provided.

@VBproDev
Copy link
Owner

VBproDev commented Nov 5, 2024

@Axorax I thoroughly tested your branch, and the design breaks when the link to call Bootstrap (through CDN) is removed. Isn't the whole point of this PR is to remove Bootsrap and make stuff look better (like in your design).

@Axorax
Copy link
Collaborator Author

Axorax commented Nov 5, 2024

@Axorax I thoroughly tested your branch, and the design breaks when the link to call Bootstrap (through CDN) is removed. Isn't the whole point of this PR is to remove Bootsrap and make stuff look better (like in your design).

No. The point is to make the UI look better, not remove bootstrap.

I also made it mobile responsive. But the UI works along with bootstrap, not as a replacement.

I think you merging the previous PR and reverting it introduced some conflicts. Might need to handle those to merge this PR.

@VBproDev
Copy link
Owner

VBproDev commented Nov 5, 2024

No need to worry about the conflicts, I will resolve them. Just fix the footer for mobile (its broken there), I will merge this brach with main.

@Axorax
Copy link
Collaborator Author

Axorax commented Nov 5, 2024

No need to worry about the conflicts, I will resolve them. Just fix the footer for mobile (its broken there), I will merge this brach with main.

All fixed and working as expected!

image
image

@VBproDev VBproDev merged commit d00b544 into VBproDev:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants