Gogi/improvements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Author
| @itsmebasti I tested it is settings and it works. So if all is ok merge it into master. |
Fixed tests and added resource icon as unpacckaged
itsmebasti reviewed Oct 20, 2020
itsmebasti left a comment
itsmebasti left a comment There was a problem hiding this comment.
all good, feel free to merge it 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
@itsmebasti Do not merge it yet it is just for review i will test it with this branch.
When I say it is good to merge merge as squash commit.