[WIP] Feature: Keyboard Shortcuts (rebased on master) #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
seveibar commented Mar 19, 2020
seveibar changed the title seveibar commented Mar 19, 2020
seveibar commented Mar 19, 2020
| | {| type: "HEADER_BUTTON_CLICKED", buttonName: string |} | ||
| | {| type: "SELECT_TOOL", selectedTool: string |} | ||
| | {| type: "SELECT_TOOL", selectedTool: ToolEnum |} | ||
| | {| type: "CANCEL" |} |
There was a problem hiding this comment.
need to add new actions here...
{| type: "GO_TO_NEXT_IMAGE" |}
{| type: "GO_TO_PREV_IMAGE" |}
seveibar commented Mar 19, 2020
src/Shortcuts/index.js Outdated
| }, | ||
| "next-image": { | ||
| //TODO: { type: "GO_TO_NEXT_IMAGE" } | ||
| name: "Next Image" |
There was a problem hiding this comment.
each of these should have static actions defined. e.g.
// ... "next-image": { "name": "Next Image", "action": { type: "GO_TO_NEXT_IMAGE" } } // ... seveibar commented Mar 19, 2020
| onShortcutActionDispatched({ | ||
| type: "SELECT_TOOL", | ||
| selectedTool: actionId | ||
| }) |
There was a problem hiding this comment.
change this to...
onShortcutActionDispatched(shortcut.action)
| In //... case "GO_TO_NEXT_IMAGE": return setIn(state, ["selectedImage"], (currentImageIndex + 1) % state.images.length) //... |
…e to defaultShortcuts too
…reducers for next image and previous image and they added a and d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Original work by @puskuruk but for some reason github stopped tracking authorship after rebase