[WIP] Feat/custom region form #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ThibautGeriz force-pushed the feat/custom-region-form branch from fcedbbe to d20b9a8 Compare 
| Hey @ThibautGeriz, I like how in this implementation you allow replacing the "RegionLabel" component. tbh I don't love having I'd like to help refactor this or have someone on the wao.ai team help. I'll respond later with more details. Thanks so much for the contribution! We'll get this merged :) |
ThibautGeriz force-pushed the feat/custom-region-form branch from d3b8f38 to 7ac84b9 Compare 
| @seveibar I've done the requested updates. Let me know when you have time for a full time code review. |
| This looks good to me. |
seveibar approved these changes Apr 3, 2020
| So I'm going to merge this but we'll need to do just a bit of testing, then it'll go into the next release. |
stajahlee pushed a commit to skiplist-eng/react-image-annotate that referenced this pull request Apr 3, 2020
feat: Feat/custom region form (UniversalDataTool#32)
seveibar pushed a commit that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We a more complex use case on the photo classification, I made the following changes:
EditFormto provide a custom react componentQuestions: