Allow to hide any of the header buttons and update the Readme with the new options #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…ith the new options.
seveibar requested changes Oct 14, 2021
| | `hideClone` | `boolean` | Hide `Clone` button from the header bar. | `false` | | ||
| | `hideSettings` | `boolean` | Hide `Settings` button from the header bar. | `false` | | ||
| | `hideFullScreen` | `boolean` | Hide `FullScreen/Window` button from the header bar. | `false` | | ||
| | `hideSave` | `boolean` | Hide `Save` button from the header bar. | `false` | |
src/MainLayout/index.js Outdated
| | ||
| | ||
| | ||
| |
There was a problem hiding this comment.
hmm lots of empty lines, can you run prettier against this file
There was a problem hiding this comment.
Sure, I didn't notice this!
seveibar approved these changes Oct 15, 2021
| Hello @seveibar! It seems that the deployment pipeline has failed, can you check the node version that is failing? |
| It seems that these props don't work in my app. I've set these hide props to be true but these buttons are still displayed. |
holmanlam pushed a commit to holmanlam/react-image-annotate that referenced this pull request Jul 20, 2022
# [1.9.0](v1.8.0...v1.9.0) (2022-07-20) ### Bug Fixes * change node version to 14 ([2c02d81](2c02d81)) * Merge pull request [UniversalDataTool#178](https://github.com/holmanlam/react-image-annotate/issues/178) from josepdecid/master ([05e6f9e](05e6f9e)) * update node version ([262f3aa](262f3aa)) ### Features * Merge pull request [UniversalDataTool#185](https://github.com/holmanlam/react-image-annotate/issues/185) from HenryLiangzy/master ([ca3e864](ca3e864)) * new version released ([334f5e0](334f5e0))
| @Cr7st me too, have you found any solution ? |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've seen some issues like #104 that requested a way to choose which buttons to show or hide from the header bar. I have found the same "problem" (lack of feature) with a project of mine. Checking the code, I've seen that there were already a
hidePrevandhideNextbuttons that were not well documented.Therefore, I have added a hide option for the rest of the buttons: Clone, Settings, Save and FullScreen/Window. I have also added the information about the existence of these properties in the Readme Props section.
I've noticed now that there are a noticeable amount of changes with the imports. Still, it's just the IDE that auto-sorted it automatically without me noticing it.