Fix serialization of RigidBodySensorComponents #5780
+33 −16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The settings of `RigidBodySensorComponent`s were not getting serialized and saved properly before. Now they are. Fixes Unity-Technologies#5774
…null check Having the update of the internal object where it was was causing problems, so put it back at the end. Also, for some reason I will never understand, the `ReferenceEquals` check on `RootBody` was sometimes returning false even when it was set to `null`, so add an extra check for Unity `null`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
The settings of
RigidBodySensorComponents were not getting serializedand saved properly before. Now they are.
Fixes #5774
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments