Skip to content

Redo dotnet format #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 16, 2021
Merged

Redo dotnet format #5119

merged 4 commits into from
Mar 16, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Mar 15, 2021 •
edited
Loading

Proposed change(s)

Now that dotnet-format has upstream support, we can remove the hacky script and just use the provided hook.

Note: requires identity>=2.1.2 installed to run with pre-commit locally.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

dotnet/format#872

Types of change(s)

  • CI
@chriselion chriselion requested a review from surfnerd March 15, 2021 23:30
@surfnerd
Copy link
Contributor

:shipit:
@chriselion chriselion merged commit ff3d608 into main Mar 16, 2021
@delete-merged-branch delete-merged-branch bot deleted the redo-dotnet-format branch March 16, 2021 01:33
@ervteng
Copy link
Contributor

ervteng commented Mar 16, 2021

BTW, if anyone else runs into pre-commit issues after this commit, you have to have dotnet version newer than 3.1. I had 2.1 and had to reinstall using the mac installer here.
@chriselion chriselion mentioned this pull request Mar 16, 2021
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@chriselion @surfnerd @ervteng