Turns physics modules into optional dependencies. #5112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
surfnerd force-pushed the develop-physics-optional-dep branch from 5994dff to a27e9b1 Compare 
chriselion reviewed Mar 15, 2021
com.unity.ml-agents/Editor/RayPerceptionSensorComponentBaseEditor.cs Outdated Show resolved Hide resolved
surfnerd force-pushed the develop-physics-optional-dep branch from a27e9b1 to f17d9c9 Compare surfnerd force-pushed the develop-physics-optional-dep branch from e6f24a8 to f9e99da Compare chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
chriselion reviewed Mar 17, 2021
surfnerd commented Mar 17, 2021
| NOT pull_request.draft AND | ||
| (pull_request.changes.any match "com.unity.ml-agents/**" OR | ||
| pull_request.changes.any match ".yamato/com.unity.ml-agents-test.yml") | ||
| optional_deps: |
There was a problem hiding this comment.
yml to test the package with different project setups to ensure all tests pass with each optional dependency removed.
surfnerd commented Mar 17, 2021
| "dependencies": { | ||
| "com.unity.ml-agents": "1.9.0-preview" | ||
| "com.unity.ml-agents": "1.9.0-preview", | ||
| "com.unity.modules.physics": "1.0.0" |
There was a problem hiding this comment.
add this for physics sensors in extensions.
surfnerd commented Mar 17, 2021
surfnerd commented Mar 17, 2021
surfnerd commented Mar 17, 2021
surfnerd commented Mar 17, 2021
surfnerd commented Mar 17, 2021
surfnerd commented Mar 17, 2021
surfnerd commented Mar 17, 2021
com.unity.ml-agents/Runtime/SideChannels/TrainingAnalyticsSideChannel.cs Outdated Show resolved Hide resolved
surfnerd force-pushed the develop-physics-optional-dep branch from cb06ec5 to b4e832f Compare chriselion reviewed Mar 19, 2021
chriselion reviewed Mar 19, 2021
chriselion reviewed Mar 19, 2021
com.unity.ml-agents/Runtime/Sensors/RayPerceptionSensorComponent2D.cs Outdated Show resolved Hide resolved
surfnerd force-pushed the develop-physics-optional-dep branch 2 times, most recently from 78db448 to ff2184e Compare 
surfnerd force-pushed the develop-physics-optional-dep branch from 03ffbbf to acb9987 Compare chriselion reviewed Mar 22, 2021
| testProject: DevProject | ||
| enableNoDefaultPackages: !!bool true | ||
| - version: 2019.4 | ||
| enableCodeCoverage: !!bool true |
There was a problem hiding this comment.
Can remove enableCodeCoverage now, right?
chriselion reviewed Mar 22, 2021
| { | ||
| // Set to the 2D defaults (just in case they ever diverge). | ||
| RayLayerMask = Physics2D.DefaultRaycastLayers; | ||
| RayLayerMask = -5; |
There was a problem hiding this comment.
Don't need this anymore, now that we're always using k_PhysicsDefaultLayers in the base class. (sorry, github wouldn't let me do a multi-line suggestion).
chriselion approved these changes Mar 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
#5104 (Make both physics modules optional dependencies (com.unity.modules.physics and com.unity.modules.physics2d))
MLA-1850
Types of change(s)
Checklist
Other comments