Skip to content

Messages will be consumed when the side channel registers #3573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: Adding example project hint to Discrete Action Mask section
merged 3 commits into from
Mar 5, 2020
Merged

Messages will be consumed when the side channel registers #3573

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b160db
Messages will be consumed when the side channel registers
vincentpierre Mar 5, 2020
481c14f
addressing the comment
vincentpierre Mar 5, 2020
760d4f5
Update com.unity.ml-agents/Runtime/Communicator/RpcCommunicator.cs
vincentpierre Mar 5, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions com.unity.ml-agents/Runtime/Communicator/RpcCommunicator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,20 @@ public void RegisterSideChannel(SideChannel sideChannel)
"A side channel with type index {0} is already registered. You cannot register multiple " +
"side channels of the same id.", channelId));
}

var numMessages = m_CachedMessages.Count;
for (int i = 0; i < numMessages; i++)
{
var cachedMessage = m_CachedMessages.Dequeue();
if (channelId == cachedMessage.ChannelId)
{
sideChannel.OnMessageReceived(cachedMessage.Message);
}
else
{
m_CachedMessages.Enqueue(cachedMessage);
}
}
m_SideChannels.Add(channelId, sideChannel);
}

Expand Down