[AIRO-302] Add pick&place docker #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
peifeng-unity requested review from LaurieCheers-unity, at669, mpinol and mrpropellers 
mrpropellers suggested changes Dec 1, 2020
Comment on lines 179 to 182
| 1. Run ROS in a new docker container | ||
| | ||
| ```bash | ||
| docker run -it --rm -p 10000:10000 -p 5005:5005 unity-robotics:pick-and-place part_3 /bin/bash |
There was a problem hiding this comment.
I'd include a link here to the docker build instructions in Part 2 in case a user has skipped ahead or is for some other reason confused about where this container came from.
peifeng-unity force-pushed the add-pnp-docker branch from 0b81e5c to 1e9f46b Compare mrpropellers previously approved these changes Dec 3, 2020
mrpropellers approved these changes Dec 7, 2020
| Thank @mrpropellers that the docker build and run would work on Windows, macOS, and Ubuntu platforms. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Package ROS side services into a docker container so that users could skip the preparations of the ROS environment. Tested on macOS and Ubuntu, and both work well.