AIRO-1941 Justing/add visualization layer support #290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 2 commits July 7, 2022 10:04
| SerializedProperty layer = property.FindPropertyRelative("LayerNumber"); | ||
| position = EditorGUI.PrefixLabel(position, GUIUtility.GetControlID(FocusType.Passive), label); | ||
| if (layer != null) | ||
| layer.intValue = EditorGUI.LayerField(position, layer.intValue); |
Contributor
There was a problem hiding this comment.
Nice. Though you really shouldn't have to go to this much trouble, there should be a SelectableLayer struct predefined in the engine...
| { | ||
| "name": "com.unity.robotics.visualizations", | ||
| "version": "0.7.1-preview", | ||
| "version": "0.7.2-preview", |
Contributor
There was a problem hiding this comment.
We don't bump the version number until the changes get merged to main.
LaurieCheers-unity approved these changes Jul 13, 2022
hyounesy reviewed Jul 26, 2022
Contributor
hyounesy left a comment
hyounesy left a comment There was a problem hiding this comment.
I verified that visualizations don't show up in the rgb and stereo sensors.
hyounesy changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
PR adds a property to Drawing3dManager to allow the developer to specify the layer to render into.
This PR just adds the support to specify the layer, and it defaults to UI.
A followup PR will be needed for RoboticsSensors that use cameras, to optionally grab this layer index (if the visualizations package is present) and set the layer mask appropriately.
Useful links (GitHub issues, JIRA tickets, forum threads, etc.)
https://jira.unity3d.com/browse/AIRO-1941
Types of change(s)
Testing and Verification
Please describe the tests that you ran to verify your changes. Please also provide instructions, ROS packages, and Unity project files as appropriate so we can reproduce the test environment.
Test Configuration:
Checklist
devbranchdevbranchOther comments