Skip to content

AIRO-1464 Add a try catch so that bad logic from one received message doesn't c… #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peifeng-unity merged 3 commits into from
Nov 8, 2021
Merged

AIRO-1464 Add a try catch so that bad logic from one received message doesn't c… #227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d080b2
Add a try catch so that bad logic from one received message doesn't c…
P3TE-QUT Oct 25, 2021
d0fe4d6
Merge branch 'dev' into p3te/subscriber_error_catch
hyounesy Oct 29, 2021
16d2b46
Merge branch 'dev' into p3te/subscriber_error_catch
P3TE-QUT Nov 2, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion com.unity.robotics.ros-tcp-connector/Runtime/TcpConnector/ROSConnection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,19 @@ void Update()
// if this is null, we have received a message on a topic we've never heard of...!?
// all we can do is ignore it, we don't even know what type it is
if (topicInfo != null)
topicInfo.OnMessageReceived(contents);
{
try
{
//Add a try catch so that bad logic from one received message doesn't
//cause the Update method to exit without processing other received messages.
topicInfo.OnMessageReceived(contents);
}
catch (Exception e)
{
Debug.LogException(e);
}

}
}
}
}
Expand Down