Skip to content

Conversation

@P3TE
Copy link
Contributor

@P3TE P3TE commented Oct 8, 2021

Fixing a small bug in the RosTopicState.cs where MessageSender would always be null

Proposed change(s)

Describe the changes made in this PR.

Useful links (GitHub issues, JIRA tickets, forum threads, etc.)

Provide any relevant links here.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Documentation update
  • Other (please describe)

Checklist

  • Ensured this PR is up-to-date with the dev branch
  • Created this PR to target the dev branch
  • Followed the style guidelines as described in the Contribution Guidelines
  • Added tests that prove my fix is effective or that my feature works
  • Updated the Changelog and described changes in the Unreleased section
  • Updated the documentation as appropriate

Other comments

@LaurieCheers-unity LaurieCheers-unity merged commit 70284f5 into Unity-Technologies:dev Oct 13, 2021
@LaurieCheers-unity
Copy link
Contributor

By the way, if this is your only change, I hope that means I didn't break your Publisher component too badly! Did my best to refactor it carefully but I'm sure you have usecases I didn't consider...

@P3TE
Copy link
Contributor Author

P3TE commented Oct 13, 2021

@LaurieCheers-unity There wasn't much trouble when pulling in the refactored changes. A couple of naming changes but other than that everything on my end seems to be working fine!

@P3TE P3TE deleted the dev_null_reference_message_sender_fix branch October 14, 2021 01:30
@P3TE
Copy link
Contributor Author

P3TE commented Oct 14, 2021

@LaurieCheers-unity - ooops, spoke too soon:
#211
#212
Haha, they're not big fixes though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants