CHANGE: Remove standaloneil2cpp tests on Ubuntu from PR trigger and add them to nightly trigger #2259
+205 −211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr-agent |
windxu88 changed the title ![u-pr-agent[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@ ## develop #2259 +/- ## =========================================== - Coverage 76.70% 76.62% -0.09% =========================================== Files 465 472 +7 Lines 87919 88289 +370 =========================================== + Hits 67442 67653 +211 - Misses 20477 20636 +159 Flags with carried forward coverage won't be shown. Click here to find out more. see 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ekcoh approved these changes Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Standalone-il2cpp tests on Ubuntu 22 are unstable because Editor can freeze when building the player in this environment.
This PR:
3600 secondsto UTR command in all test jobs which should be enough. I have checked all the jobs, their run time are all under 30 minutes. After setting the timeout value, a job won't be stuck there for 6 hours.all performance testsandstandalone-il2cpp tests on Ubuntu.Testing status & QA
Please describe the testing already done by you and what testing you request/recommend QA to execute. If you used or created any testing project please link them here too for QA.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: