FIX: Removing dependencies on VRModule #2251
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@ ## develop #2251 +/- ## =========================================== - Coverage 76.70% 76.63% -0.08% =========================================== Files 465 472 +7 Lines 87919 88278 +359 =========================================== + Hits 67442 67648 +206 - Misses 20477 20630 +153 Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…System into vrmodule-deprecation
|
|
RogPodge changed the title 
| #pragma warning restore CS0618 | ||
| } | ||
| #endif | ||
| } |
There was a problem hiding this comment.
Nice. Can we remove the now empty Awake and OnDestroy as well? Thanks
There was a problem hiding this comment.
No because they are protected virtual and users may have created derived scripts that use them. It would be a breaking change to remove the methods.
There was a problem hiding this comment.
I had tried to remove the methods and it got caught against CI. Unfortunately, we have to leave in the empty methods for now.
There was a problem hiding this comment.
I thought those Awake/Start/etc were the MonoBehaviour magic methods that are invoked by name from the native code if present, it didn't matter whether they were public, private, virtual or not. But ok, let it be for now.
Packages/com.unity.inputsystem/InputSystem/Plugins/XR/TrackedPoseDriver.cs Show resolved Hide resolved
| LGTM, I don't have any XR devices so I only checked whether there's any problems when adding XR packages across our supported editor versions |
7 participants
Description
The VR Module is obsolete and slated to be removed in a future version of Unity: https://docs.unity3d.com/6000.3/Documentation/ScriptReference/UnityEngine.VRModule.html
This PR removes the dependency of the Input System Package from the VR Module. There is one functional change to the PR, where the AutoXRCameraTracking is disabled during
AwakeandOnDestroy. This function only works when using the Legacy XR Framework, and does nothing when using the modern XR architecture.Testing status & QA
N/A
Overall Product Risks
Comments to reviewers
Removal of the dependency on the VR Module will help make the full removal of the VR Module easier in the future.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: