Skip to content

Rename UtTestCase #519 #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sergeypospelov merged 3 commits into from
Jul 14, 2022
Merged

Rename UtTestCase #519 #517

sergeypospelov merged 3 commits into from
Jul 14, 2022

Conversation

@sergeypospelov
Copy link
Member

@sergeypospelov sergeypospelov commented Jul 13, 2022 •
edited
Loading

Description

  • Renamed UtTestCase class to UtMethodTestSet.
  • Also renamed all related local variables and functions to ...testSet....
  • Along with this, renamed UtValueTestCase to UtMethodValueTestSet. FYI: it's only used in our tests.

Fixes #519

Type of Change

  • Refactoring (typos and non-functional changes)

Checklist:

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • No new warnings
  • All tests pass locally with my changes
@sergeypospelov sergeypospelov force-pushed the sergey/ut-test-case-refactoring branch from 9fe794a to ba1ac51 Compare July 13, 2022 12:17
@sergeypospelov sergeypospelov changed the title UtTestCase refactor Rename UtTestCase Jul 13, 2022
@sergeypospelov sergeypospelov changed the title Rename UtTestCase Rename UtTestCase #519 Jul 13, 2022
mmvpm
mmvpm requested changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@mmvpm mmvpm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the following as well:

  • org/utbot/sarif/SarifReport.kt:73
  • org/utbot/framework/plugin/sarif/GenerateTestsAndSarifReportFacade.kt:35
  • org/utbot/framework/plugin/sarif/GenerateTestsAndSarifReportFacade.kt:72
  • org/utbot/contest/Contest.kt:336
  • org/utbot/external/api/UtBotJavaApi.kt:111
@mmvpm
Copy link
Collaborator

mmvpm commented Jul 13, 2022

Also:

  • examples/SummaryTestCaseGeneratorTest.kt:100
  • org/utbot/framework/codegen/model/constructor/tree/CgTestClassConstructor.kt:53
  • org/utbot/examples/UtModelTestCaseChecker.kt:96
  • org/utbot/examples/UtValueTestCaseChecker.kt:2295
@mmvpm
Copy link
Collaborator

mmvpm commented Jul 13, 2022

Also:

  • org/utbot/examples/UtValueTestCaseChecker.kt:2339
  • org/utbot/examples/UtValueTestCaseChecker.kt:2479
  • org/utbot/framework/plugin/api/FuzzerTestCaseGeneratorTest.kt:18
@sergeypospelov
Copy link
Member Author

sergeypospelov commented Jul 13, 2022

Looks like

  • org/utbot/contest/Contest.kt:336

shouldn't be renamed
@mmvpm
Copy link
Collaborator

mmvpm commented Jul 13, 2022

Also:

  • org/utbot/cli/BunchTestGeneratorCommand.kt:107
  • org/utbot/cli/GenerateTestsCommand.kt:105
  • org.utbot.cli.GenerateTestsAbstractCommand#generateTestSets
  • org/utbot/framework/coverage/CoverageCalculator.kt:143
  • org/utbot/intellij/plugin/generator/CodeGenerationController.kt:98
@sergeypospelov sergeypospelov requested a review from mmvpm July 13, 2022 13:15
mmvpm
mmvpm requested changes Jul 13, 2022
View reviewed changes
Copy link
Collaborator

@mmvpm mmvpm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also:

  • org/utbot/external/api/UtBotJavaApi.kt:153 (with comment)
  • org/utbot/external/api/UtBotJavaApi.kt:105
  • (?) org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt:1365
  • (?) org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt:1312
  • (?) org/utbot/framework/codegen/model/constructor/tree/CgTestClassConstructor.kt:44
@sergeypospelov
Copy link
Member Author

sergeypospelov commented Jul 13, 2022

  • (?) org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt:1365
  • (?) org/utbot/framework/codegen/model/constructor/tree/CgMethodConstructor.kt:1312

Looks like these uses of "case" are correct.
@sergeypospelov sergeypospelov requested a review from mmvpm July 13, 2022 13:46
@sergeypospelov sergeypospelov force-pushed the sergey/ut-test-case-refactoring branch from c6ab919 to e8b13db Compare July 13, 2022 14:07
@sergeypospelov sergeypospelov force-pushed the sergey/ut-test-case-refactoring branch from e8b13db to 861990c Compare July 13, 2022 14:09
@sergeypospelov sergeypospelov merged commit 08ded2a into main Jul 14, 2022
@sergeypospelov sergeypospelov deleted the sergey/ut-test-case-refactoring branch July 14, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@sergeypospelov @mmvpm