Skip to content

Make SpringTypeReplacer actually call its delegate #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
EgorkaKulikov merged 1 commit into from
Aug 1, 2023
Merged

Make SpringTypeReplacer actually call its delegate #2465

EgorkaKulikov merged 1 commit into from
Aug 1, 2023

Conversation

@IlyaMuravjov
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov commented Jul 31, 2023 •
edited
Loading

Description

Make SpringTypeReplacer call its delegates, so default non-Spring-specific type replacements are still used in Spring projects.

How to test

Manual tests

Generate unit tests (with and without configuration) on different Spring projects.

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.
@IlyaMuravjov IlyaMuravjov added ctg-enhancement New feature, improvement or change request comp-symbolic-engine Issue is related to the symbolic execution engine comp-spring Issue is related to Spring projects support labels Jul 31, 2023
@IlyaMuravjov IlyaMuravjov force-pushed the ilya_m/spring_traverser_context_delegation branch from e93f76f to 8a902ed Compare July 31, 2023 12:14
@IlyaMuravjov IlyaMuravjov changed the title Make SpringNonNullSpeculator and SpringTypeReplacer actually call their delegates Make SpringTypeReplacer actually call its delegate Jul 31, 2023
@EgorkaKulikov EgorkaKulikov merged commit 124384f into main Aug 1, 2023
@EgorkaKulikov EgorkaKulikov deleted the ilya_m/spring_traverser_context_delegation branch August 1, 2023 06:42
@alisevych alisevych added this to the Spring Phase 4 milestone Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-spring Issue is related to Spring projects support comp-symbolic-engine Issue is related to the symbolic execution engine ctg-enhancement New feature, improvement or change request

5 participants

@IlyaMuravjov @tepa46 @EgorkaKulikov @alisevych