- Notifications
You must be signed in to change notification settings - Fork 45
Refactor to reduce coupling of base UtBot implementation with Spring-specific features #2411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a7aaf80 to 6569628 Compare ApplicationContext into multiple interfaces19cb36d to 2874151 Compare
Damtev left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| } | ||
| } | ||
| | ||
| class SimpleUtExecutionInstrumentation( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's extract it to a separate file
| classfileBuffer: ByteArray | ||
| ) = null | ||
| | ||
| class Factory : Instrumentation.Factory<Result<*>, InvokeInstrumentation> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not object?
| } | ||
| } | ||
| | ||
| class Factory : Instrumentation.Factory<Trace, ExecutionTraceInstrumentation> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not object?
| return instrumenter.classByteCode | ||
| } | ||
| | ||
| class Factory : Instrumentation.Factory<Result<*>, CoverageInstrumentation> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not object?
| } | ||
| } | ||
| | ||
| class Factory : Instrumentation.Factory<Result<*>, InvokeWithStaticsInstrumentation> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not object?
396a4fb to 186a0fb Compare …NullPointerException` into one method
…lementors` with `beanDefinitions.isNotEmpty()`
…pplicationContext` type
…arams in functions and constructors
f9a6a20 to dbf4da7 Compare
Description
Fixes #2358, #2226
How to test
Regression tests (this pull request should not change UtBot semantics at all)
Self-check list