Skip to content

Conversation

@amandelpie
Copy link
Collaborator

@amandelpie amandelpie commented Jun 17, 2022

Description

First of all, provides bug-fix for a minor bug.

To cover this bug with unit-tests this PR proposes some changes in the project architecture: I moved outdated and disabled summary tests to the separate utbot-summary-tests module to avoid circular dependency from the utbot-analytics module that keeps stuff related to the Path Selectors only.

Moreover I did some minor refactoring in utbot-summary module.

Fixes #198

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I've added a new test especially for this scenario (preprocessed code from guava-26 with Stats.of method and some related method and classes)

Checklist (remove irrelevant options):

  • The change followed the style guidelines of the UTBot project
  • Self-review of the code is passed
  • The change contains enough commentaries, particularly in hard-to-understand areas
  • New documentation is provided or existed one is altered
  • No new warnings
  • Tests that prove my change is effective
  • All tests pass locally with my changes
@amandelpie amandelpie added ctg-bug Issue is a bug comp-summaries Something related to the method names, code comments and display names generation labels Jun 17, 2022
@amandelpie amandelpie requested a review from denis-fokin June 20, 2022 12:29
@amandelpie amandelpie force-pushed the amandelpie/feature-198 branch from fe9da3f to 2522ab6 Compare June 21, 2022 10:16
@amandelpie
Copy link
Collaborator Author

@denis-fokin tests are green, please make review, I need this module changes to make summary tests great again

@denis-fokin denis-fokin requested a review from dtim June 22, 2022 08:23
@amandelpie amandelpie enabled auto-merge (squash) June 22, 2022 11:50
@amandelpie amandelpie merged commit 81d7bd1 into main Jun 23, 2022
@amandelpie amandelpie deleted the amandelpie/feature-198 branch June 23, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp-summaries Something related to the method names, code comments and display names generation ctg-bug Issue is a bug

4 participants