Prune branches with unexpected mocks #1889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
EgorkaKulikov added comp-symbolic-engine EgorkaKulikov changed the title EgorkaKulikov force-pushed the egor/force_mock_correction branch from abb9bf9 to ac8e68a Compare EgorkaKulikov changed the title 
Damtev requested changes Mar 6, 2023
Member
Damtev left a comment
Damtev left a comment There was a problem hiding this comment.
There are some suspicious parts
utbot-framework-test/src/test/kotlin/org/utbot/examples/mock/CommonMocksExampleTest.kt Outdated Show resolved Hide resolved
utbot-framework-test/src/test/kotlin/org/utbot/examples/mock/CommonMocksExampleTest.kt Outdated Show resolved Hide resolved
utbot-framework-api/src/main/kotlin/org/utbot/framework/plugin/api/Api.kt Show resolved Hide resolved
EgorkaKulikov force-pushed the egor/force_mock_correction branch from a82d310 to a696c82 Compare 
CaelmBleidd requested changes Mar 7, 2023
EgorkaKulikov force-pushed the egor/force_mock_correction branch from 032a31a to efe2b62 Compare 
Damtev approved these changes Mar 13, 2023
denis-fokin pushed a commit that referenced this pull request Mar 13, 2023
CaelmBleidd pushed a commit that referenced this pull request Mar 14, 2023
tamarinvs19 pushed a commit that referenced this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (1560)
We need to stop symbolic execution if we called
forceMockfunction andDo not mockstrategy is used.One of possible scenarios is when there are no implementations of an interface in project while
NO_MOCKSstrategy is selected.To obtain this, some branch pruning is introduced.
Job cancellations are removed from mock listeners.
How to test
Automated tests
Corrected test:
testMockInterfaceWithoutImplementorsWithNoMocksStrategyAdded test:
testMockInterfaceWithoutImplementorsWithMockingStrategyManual tests
Scenario from issue.
Self-check list