Fixed copyOf, copyOfRange and asList failures #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Damtev added the comp-symbolic-engine Damtev force-pushed the damtev/as_list_fix branch from 73f070b to f7ccac2 Compare 
CaelmBleidd requested changes Jan 18, 2023
| package org.utbot.engine.overrides.stream; | ||
| | ||
| import org.utbot.api.annotation.UtClassMock; | ||
| import org.utbot.api.mock.UtMock; |
Comment on lines 265 to 266
| wrap(UtArrayList::class) { _, addr -> objectValue(LIST_TYPE, addr, ListWrapper(UT_ARRAY_LIST)) }, | ||
| wrap(UtLinkedList::class) { _, addr -> objectValue(LIST_TYPE, addr, ListWrapper(UT_LINKED_LIST)) }, |
There was a problem hiding this comment.
Why are they have a list type here? In the wrappers above (e.g. UtStringBuilder and UtStringBuffer) you use concrete types instead of a common interface. Why?
Comment on lines 3239 to 3242
| return MethodResult( | ||
| newArray, | ||
| memoryUpdates = arrayUpdateWithValue(newArray.addr, arrayType, selectArrayExpressionFromMemory(src)) | ||
| ) |
There was a problem hiding this comment.
I don't get it. You just created a new array with all unbounded variables. Why is it a copy of the original one? Or you copied the whole original massive even though it might be bigger than a copy? If it is so, please, provide a corresponding comment here
| val to = parameters[2] as PrimitiveValue | ||
| | ||
| val originalLength = memory.findArrayLength(original.addr) | ||
| |
There was a problem hiding this comment.
Seems like a missed NPE check
| queuedSymbolicStateUpdates += mkNot(isFromBiggerThanTo).asHardConstraint() | ||
| | ||
| val newLength = Sub(to, from) | ||
| val newLengthValue = PrimitiveValue(IntType.v(), newLength) |
| internal val CLASS_REF_SOOT_CLASS: SootClass | ||
| get() = Scene.v().getSootClass(CLASS_REF_CLASSNAME) | ||
| internal val ARRAYS_SOOT_CLASS: SootClass | ||
| get() = Scene.v().getSootClass("java.util.Arrays") |
There was a problem hiding this comment.
Please, use a java class and its name for consistency with the code below
Damtev force-pushed the damtev/as_list_fix branch from f7ccac2 to 9cf6966 Compare CaelmBleidd approved these changes Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Since real implementations of
Arrays.copyOfandArrays.copyOfRangeare pretty difficult (due to reflection usage) for the symbolic engine, symbolic implementations are added in this PR. Also, since the mock implementation ofArrays.asListreturns an instance of our classUtArrayList, some wrap hacks were added to prevent its appearance as a result of execution.Fixes #1699 .
Type of Change
How Has This Been Tested?
Automated Testing
org.utbot.examples.arrays.CopyOfExampleTestandorg.utbot.examples.collections.ListsPart3Test#testAsListExampleManual Scenario
org.antlr.v4.codegen.model.Recognizer.translateTokenStringsToTargetin Contest Estimator.Checklist (remove irrelevant options):