Remove JS dependencies #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ddworak reviewed Aug 3, 2018
README.md Outdated
| integrity="sha256-FgpCb/KJQlLNfOu91ta32o/NMZxltwRo8QtmkMRdAu8=" | ||
| crossorigin="anonymous"></script> | ||
| ``` | ||
| * [Scala.js dependency](http://www.scala-js.org/doc/project/dependencies.html). |
There was a problem hiding this comment.
"or a"? If I didn't know, I'd add both. Also the jsDependency variant is not equal to adding a script in html - you still need to add a script tag or load this from JS.
There was a problem hiding this comment.
The linked Scala.js doc describes how to work with js deps. I think we don't need to copy it here.
ddworak approved these changes Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since Scala.js 1.0 this mechanism will be "deprecated". We should migrate to scalajs-bundler in the future.