Fix: clean parallel temp folder after test run #484
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📚 Description
This PR resolves an issue where temporary files and directories bashunit creates implicitly during a parallel run were not properly cleaned up.
It adds both a unit test an an acceptance test that fail without the fix and now pass.
This issue already existed before my changes in #483 .
🔖 Changes
parallel::cleanupand call it in each exit point when parallel mode is enabledSide note: the previous
parallel::resetfunction (which I renamed toparallel::initnow) contained the following line:IMO the condition
[ -f "$TEMP_FILE_PARALLEL_STOP_ON_FAILURE" ]could never be true, as the containing directory is deleted right before the line. Hence I removed it. If it served any purpose I overlooked, please tell me.✅ To-do list
CHANGELOG.mdto reflect the new feature or fix