Upgrade option #227
Upgrade option #227
Conversation
Chemaclass requested review from Chemaclass, JesusValeraDev, cmayo, fabriziofs and khru 
| @gpuligundla We have already made the changes we told you about to your contribution, we have made some small changes in the implementation and improved the tests Thank you again for help us! |
Co-authored-by: Antonio Gonzalez Gea <katarn@katarn.es>
| ./bin/bashunit | ||
| | ||
| if [[ $_OS == "OSX" ]]; then | ||
| rm ./bin/bashunit-e |
There was a problem hiding this comment.
./bin/bashunit-e, is that correct?
There was a problem hiding this comment.
Yes, it's correct. This is because sed behaves a it different in macOS than others.
Concretely, the option -e is used for regex in linux; while in macOS it's not needed and then it's appending -e to the file: therefore it generates a new file named 'bashunit-e' 🤣
To keep it simple, @Tito-Kati and I decided simply rm that file and we are good to go.
| | ||
| function test_do_not_update_on_consecutive_calls() { | ||
| todo "enable this test when --upgrade is released" | ||
| # sed -i -e \ |
There was a problem hiding this comment.
yes, this is intentional, we will uncomment this (and enable this test) once we have --upgrade released in the next version.
📚 Description
Closes #143
🔖 Changes
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix