Snapshots iteration 2 #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…_no_snapshot_tests_nor_assertions pass
antonio-gg-dev requested review from Chemaclass, JesusValeraDev, cmayo, fabriziofs, khru and valerangel 
Chemaclass approved these changes Nov 9, 2023
Member
Chemaclass left a comment
Chemaclass left a comment There was a problem hiding this comment.
Kudos to you, @Tito-Kati ! I love it
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
📚 Description
This is the second iteration on the snapshot functionality. With this iteration, and in my opinion, I believe this functionality could be released.
Now when the snapshots are created (executing snapshot assertion the first time), the test is not considered as having passed. Instead, they are marked with the 'snapshot' status and the user is appropriately informed that these snapshots have been created.
✅ To-do list
CHANGELOG.mdto reflect the new feature or fix