Serve fonts from origin instead of cdn #155
Conversation
antonio-gg-dev added documentation 
antonio-gg-dev left a comment
antonio-gg-dev left a comment There was a problem hiding this comment.
Hello, thank you very much for helping us with the project, would you mind making some changes to simplify it?
Since the documentation is only in English, we do not need the versions with the unicode-ranges, the standard version of each font will be sufficient, you can download them from Google Fonts.
Make sure you download the correct weights for each font, we need 400 for Cousine, 600 for Rubik, and for Heebo we need both 400 and 600.
Additionally, it would be great if the filenames of the font files have a name that can be understood.
Thank you very much again for helping us.
| I also noticed that you've updated the yarn.lock, please @Harsh-br0 restore it to the previous version as we have it there precisely to ensure we all have the same versions of the packages and to ensure that the documentation works stably. |
| Alright, my apologies for responding lately |
| Seems like my formatter messed up line endings |
| Can you please check the To-do list from the PR itself?
|
| so, i have checked first 2 checkboxes which makes sense to this PR |
| @Harsh-br0, what I would suggest is to add only one line like "Serve fonts from origin instead of cdn" to the Unreleased list from the CHANGELOG. That should be enough |
| I believe that since it's not a significant improvement for our users, there's no need to add anything to the changelog, but it would be a shame if your name didn't appear in the next release. Perhaps you could add something like "optimized docs fonts". |
| Alright, Now it seems fine |
| Nice, Thanks for such amazing library. |
3 participants
📚 Description
fixes #154
🔖 Changes
fonts.cssto link cached font filesdocs/public/fontsdirectory✅ To-do list
CHANGELOG.mdto reflect the new feature or fix