Skip to content

Little test doubles changes #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
antonio-gg-dev merged 2 commits into from
Oct 1, 2023
Merged

Little test doubles changes #131

antonio-gg-dev merged 2 commits into from
Oct 1, 2023

Conversation

@antonio-gg-dev
Copy link
Member

@antonio-gg-dev antonio-gg-dev commented Oct 1, 2023

🔖 Changes

  • On docs, i moved test doubles before assertions (similar order in PHPUnit and Jest).
  • Changed docs/test-doubles.md general descriptions/examples to fit more with the other sections.
  • Changed the fail output of assert_have_been_called and assert_have_been_called_times to be more developer-friendly
  • Test assert_have_been_called_times fail output

✅ To-do list

  • Make sure that all the pipeline passes
  • Make sure to update the CHANGELOG.md to reflect the new feature or fix
@Chemaclass Chemaclass added the documentation Improvements or additions to documentation label Oct 1, 2023
@Chemaclass
Copy link
Member

Chemaclass commented Oct 1, 2023

@Tito-Kati, to fix the CI, try adding # shellcheck disable=SC2317 to tests/unit/test_doubles_test.sh:11
@antonio-gg-dev antonio-gg-dev merged commit 066c37f into main Oct 1, 2023
@antonio-gg-dev antonio-gg-dev deleted the fix-test-doubles-docs branch October 1, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

4 participants

@antonio-gg-dev @Chemaclass @JesusValeraDev