Markup/Styling improvements #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Select text in input when the modal is opened. - Up/Down arrow keys work like Home/End, changing the caret position, that shouldn't happen, but holding Shift with these keys selects text so it doesn't make sense to block it. - The usual action of clicking the field is to toggle the listbox, but since here the listbox is always shown, so simply remove the selection/visual focus.
Now it works without having to pass the animation name as a parameter, allowing to change closing animation with just css - Add more comments clarifying the usage. - Remove incorrect comment on Modal type about Popover, as popovers are non-modal dialogs.
Follows [ARIA Breadcrumb Example](https://www.w3.org/WAI/ARIA/apg/patterns/breadcrumb/examples/breadcrumb/)
- Replace `anchorLink` call with id attribute on its container. - Replace `anchorLinkIfPresent` with `anchorTargetIfPresent` clarifying its usage. It returns the target/fragment id. - Style changes: vertically align anchor icon, enable smooth scrolling, add scroll-margin to target.
Contributor Author
| Is this a test case failing? I don't get any error on the |
Collaborator
| Yes, maybe try merging in beta? I added some tests for the default theme rendering last night. |
Contributor Author
| Oh, of course. PR changes theme output. |
Collaborator
| Changes so far LGTM |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
alert color in light theme (Contrast ratio is 5, which is 0.5 more than the required value, but not good enough for low brightness)summaryelement contentstabindex,aria-expanded,roleattributes from Index summary element