fix: Removed warning when node attribute does not correspond to a prop #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
YousefED approved these changes Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The warning we log when converting a TipTap node to BlockNote block, which triggers when a node attribute doesn't correspond to a block prop, triggers false positives on the list item block's
indexattribute. The warning isn't actually useful for diagnosing bugs since custom blocks are made using the API anyway where the warning won't trigger, so it's only useful when converting an existing TipTap node to a block, which isn't recommended and is an advanced (not even documented) use case. Therefore, this PR removes that warning altogether. Closes #308