Skip to content

Conversation

YousefED
Copy link
Collaborator

I think we went a little overboard on zIndex values.

I think this makes more sense, wdyt? can you check if the changes are "safe"?

@YousefED YousefED marked this pull request as ready for review November 18, 2024 10:32
@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
blocknote ✅ Ready (Inspect) Visit Preview Nov 20, 2024 4:21pm
blocknote-website 🛑 Canceled (Inspect) Nov 20, 2024 4:21pm
Copy link
Collaborator

@matthewlipski matthewlipski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm while we're on the subject of z-indices maybe we should also take a look at the UI element controllers? Those also have the z-index set but it's between 1000-10000. I think it would make sense if we had the same scale for both those and the examples.

@matthewlipski
Copy link
Collaborator

Well turns out the z-indices were just redundant, so I ended up removing them

@matthewlipski matthewlipski changed the title fix: sane zindex values fix: Remove redundant zindex values Nov 20, 2024
@matthewlipski matthewlipski merged commit 82c463f into main Nov 20, 2024
5 checks passed
@nperez0111 nperez0111 deleted the improve-zindex branch October 21, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants