Skip to content

fix: Made column/table resize bars get disabled when editor is non-editable #1247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2024
Merged

fix: Made column/table resize bars get disabled when editor is non-editable #1247

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f31611a
Made column resize bars get disabled when editor is non-editable
matthewlipski Nov 14, 2024
1274d83
Made table resize bars get disabled when editor is non-editable
matthewlipski Nov 14, 2024
f8bb293
Removed table non-editable fix
matthewlipski Nov 15, 2024
97af4f9
Merge branch 'main' into column-resize-non-editable
matthewlipski Nov 15, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/xl-multi-column/src/extensions/ColumnResize/ColumnResizeExtension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,10 @@ class ColumnResizePluginView implements PluginView {
getColumnHoverOrDefaultState = (
event: MouseEvent
): ColumnDefaultState | ColumnHoverState => {
if (!this.editor.isEditable) {
return { type: "default" };
}

const target = event.target as HTMLElement;

// Do nothing if the event target is outside the editor.
Expand Down
Loading