Skip to content

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Aug 13, 2025

No description provided.

@mhauru
Copy link
Member Author

mhauru commented Aug 13, 2025

Sorry, not ready for review yet. I forgot things have actually changed in 0.40...

@penelopeysm
Copy link
Member

I wonder if it's worth writing something in the dev docs about contexts vs accumulators and when one should use which?

@penelopeysm
Copy link
Member

penelopeysm commented Aug 18, 2025

The timeout seems like it's related to a Mooncake patch bump rather than anything in Turing, given that this PR is also hanging. https://github.com/TuringLang/docs/actions/runs/17044261488/job/48317651587?pr=608

So, CI hanging on a Mooncake code block is completely misleading. It's hanging because of this error with DelayDiffEq.jl: SciML/DelayDiffEq.jl#329. The observed behaviour arises from the fact that:

  1. when errors happen they don't get printed until after the entire notebook has executed.
  2. the error in this case (when you attempt to sample from a Turing model with the differential equation) spits out a stack trace containing types that are something like a million characters long. (Yeahhhhhhh, just try doing quarto render tutorials/bayesian-differential-equations/index.qmd locally.)
  3. GitHub Actions hangs whenever there's very long output. This is a known problem Long log lines slow down the runner actions/runner#1031

So from our perspective it looks like it's hanging after the last code block in the notebook, which is a Mooncake one.

Fixed on main now

Copy link
Contributor

Preview the changes: https://turinglang.org/docs/pr-previews/636
Please avoid using the search feature and navigation bar in PR previews!

@mhauru mhauru requested a review from penelopeysm September 19, 2025 16:11
Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions for wording / formatting.

While it's already quite useful getting the docs to build with a version of Turing, I have a nagging feeling that we are not documenting the things that we should be documenting very well.

For one, it looks like documenting the whole accumulators / contexts thing is just being shunted until we have more stability around the interface. That's at least sort of understandable, because who knows what's going to change in upcoming releases.

However, there are also the user-facing changes that arise from that. For example, accumulators mean that chains now contain logp + its components. This is obviously worth showing somewhere, but it isn't being shown.

I don't want that to hold this PR up, but I do think that at least new issue(s) should be made for anything that needs to be added to the docs.

@penelopeysm
Copy link
Member

(I'm otherwise happy to merge with the two changes above)

Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
@mhauru
Copy link
Member Author

mhauru commented Sep 22, 2025

I agree that we should add/improve the content. I opened these issues to track:

My goal with this PR would be to get the code examples working, and to hopefully not state anything that is plain wrong, even if it falls short of explaining all that is there.

@penelopeysm
Copy link
Member

Feel free to merge (well, after fixing the manifest :))

@mhauru mhauru merged commit 93b9868 into main Sep 23, 2025
2 checks passed
@mhauru mhauru deleted the mhauru/turing0.40 branch September 23, 2025 10:40
github-actions bot added a commit that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants