- Notifications
You must be signed in to change notification settings - Fork 104
Update to Turing 0.40 #636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Sorry, not ready for review yet. I forgot things have actually changed in 0.40... |
I wonder if it's worth writing something in the dev docs about contexts vs accumulators and when one should use which? |
So, CI hanging on a Mooncake code block is completely misleading. It's hanging because of this error with DelayDiffEq.jl: SciML/DelayDiffEq.jl#329. The observed behaviour arises from the fact that:
So from our perspective it looks like it's hanging after the last code block in the notebook, which is a Mooncake one. Fixed on main now |
Preview the changes: https://turinglang.org/docs/pr-previews/636 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor suggestions for wording / formatting.
While it's already quite useful getting the docs to build with a version of Turing, I have a nagging feeling that we are not documenting the things that we should be documenting very well.
For one, it looks like documenting the whole accumulators / contexts thing is just being shunted until we have more stability around the interface. That's at least sort of understandable, because who knows what's going to change in upcoming releases.
However, there are also the user-facing changes that arise from that. For example, accumulators mean that chains now contain logp + its components. This is obviously worth showing somewhere, but it isn't being shown.
I don't want that to hold this PR up, but I do think that at least new issue(s) should be made for anything that needs to be added to the docs.
(I'm otherwise happy to merge with the two changes above) |
Co-authored-by: Penelope Yong <penelopeysm@gmail.com>
I agree that we should add/improve the content. I opened these issues to track:
My goal with this PR would be to get the code examples working, and to hopefully not state anything that is plain wrong, even if it falls short of explaining all that is there. |
Feel free to merge (well, after fixing the manifest :)) |
No description provided.