Fix AD page, add ForwardDiff troubleshooting thing #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Preview the changes: https://turinglang.org/docs/pr-previews/618 |
| None of the text here is new and we already had two pairs of eyes on it in #595, so I think I'm just going to merge once CI passes. |
| grrrrr |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
#595, apart from attempting to define 'support tiers' for AD backends, also revamped most of the text on that page.
We couldn't quite agree on what support tiers were, so I abandoned that PR, but I think the rest of the content is still worth putting here.
In #595 I also wrote a section describing the problem associated with ForwardDiff Duals and vectors of Float. I've thus also added this to the new troubleshooting page (as was suggested in #603 (comment)). I addressed Will's comment #595 (comment) about making it clear that the type parameter option is better than making a
Vector{Real}.