Temporary workaround for static injector error #636
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
added 3 commits May 31, 2018 15:57
| Closing b/c a better workaround was suggested (preserve class names) until provider name resolution is fixed. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The Static Injector Error that is being experienced in production builds (#633) seems to be caused by the uglify-webpack-plugin or the underlying uglify-es. The temporary workaround is to set mangle to false. This will of course have the unfortunate side effect of increasing bundle size and no mangle. Although, it may be the best we can do until a patch is released.
This error can be commonly caused by a provider being used but not included in the module, this leads me to believe the provider name is de-synced during the mangle process.
Fully removing uglify did not workaround this issue either. Webpack 4 uses the same plugin internally when in production mode with the default for mangle set to true.