fixed context commands not working #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- fixed issues with requireUserInteractor and javadoc - removed obsolete prefix check that was done twice - fixed "escape of this during construction" - fail-fast for null check
| Kudos, SonarCloud Quality Gate passed! |
Zabuzard approved these changes Sep 30, 2022
Member
Zabuzard left a comment
Zabuzard left a comment There was a problem hiding this comment.
Tested, can confirm it works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I might forgot to test it properly after copying the initial PR, slash commands worked but forgot to check context commands (stupid, bad example I agree)
So therefor a fix: this also contains minor improvements of BotCore and UserInteractorPrefix
In BotCore:
Removed requireSlashCommand, and added requireUserInteractor. This works based on generics, very useful.
Also added UserInteractorPrefix#getPrefixedName(String)