Skip to content

Only allow media posts in media channels #518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Zabuzard merged 17 commits into from
Aug 28, 2022
Merged

Only allow media posts in media channels #518

Zabuzard merged 17 commits into from
Aug 28, 2022

Conversation

@Mom0aut
Copy link
Contributor

@Mom0aut Mom0aut commented Aug 19, 2022 •
edited by Zabuzard
Loading

closes #485

Config

The config was slightly changed, the following was added:

"mediaOnlyChannelPattern": "memes"
@Mom0aut Mom0aut requested review from a team as code owners August 19, 2022 07:50
@CLAassistant
Copy link

CLAassistant commented Aug 19, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
@Mom0aut Mom0aut changed the title Feature/only allow media posts in #memes Only allow media posts in #memes Aug 19, 2022
@Taz03 Taz03 added enhancement New feature or request priority: normal labels Aug 19, 2022
@Mom0aut
Copy link
Contributor Author

Mom0aut commented Aug 19, 2022

How can i check Basic checks and Code Analysis locally or how to fix them?
@Zabuzard
Copy link
Member

Zabuzard commented Aug 19, 2022

How can i check Basic checks and Code Analysis locally or how to fix them?

gradle spotless:apply or sth like that.

but u can also click on the Details link in GitHub and it will show you the issues.
@Taz03
Copy link
Member

Taz03 commented Aug 19, 2022

How can i check Basic checks and Code Analysis locally or how to fix them?

https://github.com/Together-Java/TJ-Bot/wiki/Code-Guidelines#run-spotless
Zabuzard
Zabuzard requested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@Zabuzard Zabuzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff, really high quality. Thanks for this contribution 😄
Tais993
Tais993 reviewed Aug 19, 2022
View reviewed changes
@Mom0aut Mom0aut requested a review from Zabuzard August 19, 2022 20:10
Taz03
Taz03 previously requested changes Aug 20, 2022
View reviewed changes
@Mom0aut Mom0aut requested review from Taz03 and removed request for Zabuzard August 20, 2022 01:03
Zabuzard
Zabuzard requested changes Aug 20, 2022
View reviewed changes
@Mom0aut Mom0aut requested review from Taz03 and Zabuzard and removed request for Taz03 and Zabuzard August 20, 2022 20:14
@Mom0aut Mom0aut requested review from Taz03 and Zabuzard and removed request for Zabuzard August 20, 2022 20:14
Zabuzard
Zabuzard requested changes Aug 22, 2022
View reviewed changes
@Taz03 Taz03 changed the title Only allow media posts in #memes Only allow media posts in media channels Aug 22, 2022
@Mom0aut Mom0aut requested review from Zabuzard and removed request for Taz03 August 22, 2022 16:55
@Mom0aut Mom0aut requested a review from Zabuzard August 25, 2022 19:29
Zabuzard
Zabuzard requested changes Aug 26, 2022
View reviewed changes
@Mom0aut Mom0aut mentioned this pull request Aug 27, 2022
Merged
Zabuzard
Zabuzard previously approved these changes Aug 27, 2022
View reviewed changes
@Zabuzard
Copy link
Member

Zabuzard commented Aug 28, 2022

Merging this, seems to be fine - if not, we can act afterwards. Want to accelerate development for this, need to get out a release for all the major improvements. Also, its weekened and I want to code a bit 😄
@Zabuzard Zabuzard merged commit 9d46fde into Together-Java:develop Aug 28, 2022
This was referenced Aug 28, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: normal

5 participants

@Mom0aut @CLAassistant @Zabuzard @Taz03 @Tais993