refactor(perf): make m_coords mutable to remove const_cast

Author: bobtista

Generals/Code/GameEngine/Include/GameLogic/AI.h

@@ -407,7 +407,7 @@ struct AICommandParms
  Object*	m_obj;
  Object*	m_otherObj;
  const Team*	m_team;
-std::vector<Coord3D>	m_coords;
+mutable std::vector<Coord3D>	m_coords;
  const Waypoint* m_waypoint;
  const PolygonTrigger* m_polygon;
  Int	m_intValue; /// misc usage

Generals/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp

@@ -2619,13 +2619,13 @@ void AIUpdateInterface::aiDoCommand(const AICommandParms* parms)
 privateFollowWaypointPathAsTeamExact(parms->m_waypoint, parms->m_cmdSource);
 break;
 case AICMD_FOLLOW_PATH:
-privateFollowPath(&const_cast<AICommandParms*>(parms)->m_coords, parms->m_obj, parms->m_cmdSource, FALSE);
+privateFollowPath(&parms->m_coords, parms->m_obj, parms->m_cmdSource, FALSE);
 break;
 case AICMD_FOLLOW_PATH_APPEND:
 privateFollowPathAppend(&parms->m_pos, parms->m_cmdSource);
 break;
 case AICMD_FOLLOW_EXITPRODUCTION_PATH:
-privateFollowPath(&const_cast<AICommandParms*>(parms)->m_coords, parms->m_obj, parms->m_cmdSource, TRUE);
+privateFollowPath(&parms->m_coords, parms->m_obj, parms->m_cmdSource, TRUE);
 break;
 case AICMD_ATTACK_OBJECT:
 privateAttackObject(parms->m_obj, parms->m_intValue, parms->m_cmdSource);

GeneralsMD/Code/GameEngine/Include/GameLogic/AI.h

@@ -420,7 +420,7 @@ struct AICommandParms
  Object*	m_obj;
  Object*	m_otherObj;
  const Team*	m_team;
-std::vector<Coord3D>	m_coords;
+mutable std::vector<Coord3D>	m_coords;
  const Waypoint* m_waypoint;
  const PolygonTrigger* m_polygon;
  Int	m_intValue; /// misc usage

GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AIUpdate.cpp

@@ -2681,13 +2681,13 @@ void AIUpdateInterface::aiDoCommand(const AICommandParms* parms)
 privateFollowWaypointPathAsTeamExact(parms->m_waypoint, parms->m_cmdSource);
 break;
 case AICMD_FOLLOW_PATH:
-privateFollowPath(&const_cast<AICommandParms*>(parms)->m_coords, parms->m_obj, parms->m_cmdSource, FALSE);
+privateFollowPath(&parms->m_coords, parms->m_obj, parms->m_cmdSource, FALSE);
 break;
 case AICMD_FOLLOW_PATH_APPEND:
 privateFollowPathAppend(&parms->m_pos, parms->m_cmdSource);
 break;
 case AICMD_FOLLOW_EXITPRODUCTION_PATH:
-privateFollowPath(&const_cast<AICommandParms*>(parms)->m_coords, parms->m_obj, parms->m_cmdSource, TRUE);
+privateFollowPath(&parms->m_coords, parms->m_obj, parms->m_cmdSource, TRUE);
 break;
 case AICMD_ATTACK_OBJECT:
 privateAttackObject(parms->m_obj, parms->m_intValue, parms->m_cmdSource);