Skip to content

Conversation

@sozelfist
Copy link
Contributor

Checklist:

  • I ran bellow commands using the latest version of rust nightly.
  • I ran cargo clippy --all -- -D warnings just before my last commit and fixed any issue that was found.
  • I ran cargo fmt just before my last commit.
  • I ran cargo test just before my last commit and all tests passed.
  • I added my algorithm to the corresponding mod.rs file within its own folder, and in any parent folder(s).
  • I added my algorithm to DIRECTORY.md with the correct link.
  • I checked COUNTRIBUTING.md and my code follows its guidelines.
- Rewrite docstring - Rewrite tests using macro
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.33%. Comparing base (155c767) to head (2ce0f0d).

Additional details and impacted files
@@ Coverage Diff @@ ## master #795 +/- ## ========================================== - Coverage 95.33% 95.33% -0.01%  ========================================== Files 310 310 Lines 22518 22493 -25 ========================================== - Hits 21468 21443 -25  Misses 1050 1050 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sozelfist
Copy link
Contributor Author

Can you have a look, @vil02?

@sozelfist
Copy link
Contributor Author

Can you review this PR, @vil02, it stands here for a week.

Copy link
Member

@vil02 vil02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was still some margin for improvement.

@vil02 vil02 merged commit 596697c into TheAlgorithms:master Oct 6, 2024
4 checks passed
@sozelfist sozelfist deleted the ref/string/pangram branch October 7, 2024 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants