Skip to content

Remove references to depreciated QasmSimulator #7417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Oct 19, 2022
Merged

Remove references to depreciated QasmSimulator #7417

merged 16 commits into from
Oct 19, 2022

Conversation

@tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Oct 19, 2022

Describe your change:

Replaced instances of qiskit.Aer.get_backend("qasm_simulator") in quantum/ with q.Aer.get_backend("aer_simulator"), as the former is depreciated and raises warnings (Qiskit's documentation says that QasmSimulator is legacy).

This PR edits multiple code files because they all raise the same warning and are mentioned in the same GitHub issue.

Fixes #7308

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Oct 19, 2022
cclauss
cclauss reviewed Oct 19, 2022
View reviewed changes
quantum/q_full_adder.py Outdated

import qiskit
from qiskit import Aer, ClassicalRegister, QuantumCircuit, QuantumRegister, execute
import qiskit as q
Copy link
Member

@cclauss cclauss Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using just q reduces readability for new users of qiskit and does not really save much space.

Suggested change
import qiskit as q
import qiskit
Copy link
Contributor Author

@tianyizheng02 tianyizheng02 Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made
@tianyizheng02 tianyizheng02 requested a review from cclauss October 19, 2022 18:59
cclauss
cclauss approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!!
@algorithms-keeper algorithms-keeper bot removed the awaiting reviews This PR is ready to be reviewed label Oct 19, 2022
@cclauss cclauss added hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest labels Oct 19, 2022
@cclauss cclauss merged commit 2859d4b into TheAlgorithms:master Oct 19, 2022
@tianyizheng02 tianyizheng02 deleted the qasm-simulator branch October 19, 2022 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files hacktoberfest hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

2 participants

@tianyizheng02 @cclauss