Write a proper implementation for base16 #6909
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
According to CONTRIBUTING.md:
"Algorithms in this repo should not be how-to examples for existing Python packages."
Describe your change:
The previous "implementation" for base16 imported and used a library to do it (it was just a demonstration of the
base64library), so I wrote an implementation to replace it.Checklist:
Fixes: #{$ISSUE_NO}.