improved prime_check in math modules #6044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ghost added enhancement 
poyea reviewed Mar 16, 2022
poyea reviewed Apr 3, 2022
maths/prime_check.py Outdated
| return True | ||
| elif number < 2 or not number % 2: | ||
| # Negatives, 0, 1 and all even numbers are not primes | ||
| elif number < 2 or not number % 2 or number % 3 == 0: |
Member
There was a problem hiding this comment.
Suggested change
| elif number < 2 or not number % 2 or number % 3 == 0: | |
| elif number < 2 or number % 2 == 0 or number % 3 == 0: |
There was a problem hiding this comment.
What about numbers like 25, 35, 65 etc ?
Contributor Author
There was a problem hiding this comment.
Those numbers are divisible by 5 6k-1 we are starting our loop with 5
| This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
… TheAlgorithms-master
Contributor Author
| please review my changes and give your valuable feed back |
Member
| Related #6228 |
poyea approved these changes Jul 11, 2022
Member
poyea left a comment
poyea left a comment There was a problem hiding this comment.
Thank you for your pull request!🤩
I'd approve this because this uses one of the properties - I can't tell if it's intuitive or not though
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.