Skip to content

Conversation

@dhruvmanila
Copy link
Member

Ref:

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 26, 2021
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@cclauss cclauss merged commit 6f21f76 into TheAlgorithms:master Apr 26, 2021
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Apr 26, 2021
@dhruvmanila dhruvmanila deleted the fix-ci branch April 26, 2021 13:37
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
) * fix(ci): Update pre-commit hooks and apply new black * remove empty docstring
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
) * fix(ci): Update pre-commit hooks and apply new black * remove empty docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

2 participants