Skip to content

Conversation

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Mar 20, 2021

Issue: #4052

$ git diff master --name-only  ciphers/a1z26.py  ciphers/affine_cipher.py  ciphers/atbash.py  ciphers/base32.py  ciphers/base85.py  ciphers/beaufort_cipher.py  ciphers/brute_force_caesar_cipher.py  ciphers/cryptomath_module.py  ciphers/decrypt_caesar_with_chi_squared.py  ciphers/diffie.py  ciphers/elgamal_key_generator.py  ciphers/enigma_machine2.py  ciphers/rsa_key_generator.py

Running mypy:

$ git diff master --name-only | xargs -I% mypy --strict % Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file Success: no issues found in 1 source file

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@ghost ghost added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Mar 20, 2021
@dhruvmanila dhruvmanila requested a review from cclauss March 20, 2021 09:12
Co-authored-by: Christian Clauss <cclauss@me.com>
@dhruvmanila dhruvmanila requested a review from cclauss March 22, 2021 06:42
@ghost ghost removed the awaiting reviews This PR is ready to be reviewed label Mar 22, 2021
@cclauss cclauss merged commit 14bcb58 into TheAlgorithms:master Mar 22, 2021
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Initial fix for mypy errors in some cipher algorithms * fix(mypy): Update type hints * fix(mypy): Update type hints for enigma_machine2.py * Update as per the suggestion Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
@dhruvmanila dhruvmanila deleted the fix-mypy branch April 3, 2021 10:42
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Initial fix for mypy errors in some cipher algorithms * fix(mypy): Update type hints * fix(mypy): Update type hints for enigma_machine2.py * Update as per the suggestion Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Initial fix for mypy errors in some cipher algorithms * fix(mypy): Update type hints * fix(mypy): Update type hints for enigma_machine2.py * Update as per the suggestion Co-authored-by: Christian Clauss <cclauss@me.com> Co-authored-by: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement This PR modified some existing files

2 participants