Fix is_palindrome_recursive logic in strings/palindrome.py #12946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mindaugl approved these changes Sep 3, 2025
MaximSmolskiy changed the title 
MaximSmolskiy approved these changes Sep 4, 2025
algorithms-keeper bot removed the awaiting reviews Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #12941 : Corrected base case in is_palindrome_recursive in strings/palindrome.py of Python directory.
Previously, the base case used
if len(s) <= 2: return True, which incorrectly treated any 2-character string as a palindrome (for example, "AB" returned True). Updated the base case tolen(s) <= 1so that two-character strings are compared for equality and only empty/single-character strings auto-pass.